Skip to content

Conversation

@MSP-Greg
Copy link
Collaborator

With the update "@actions/cache": "^4.0.0", along with the dependency on "@actions/core": "^1.10.0", two versions of @actions/core are listed in yarn.lock.

Update package.json to use "@actions/core": "^1.11.1".

JFYI, this started while I was working on adding windows-2025. Also, haven't looked at it yet, but 1.11.1 adds a platform object, see:

https://github.com/actions/toolkit/tree/main/packages/core#platform-helper

We may be able to use platform in the code here...

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon
Copy link
Member

eregon commented Jan 17, 2025

https://github.com/actions/toolkit/tree/main/packages/core#platform-helper

We may be able to use platform in the code here...

platform.getDetails() might be interesting, indeed.

@eregon eregon merged commit 1d54274 into ruby:master Jan 17, 2025
168 checks passed
@eregon
Copy link
Member

eregon commented Jan 17, 2025

Yep, that seems convenient, I tried it in https://github.com/ruby/setup-ruby/actions/runs/12835965709/job/35796665896#step:3:7
The Windows version is a bit less consistent (part of name), but not hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants