Less query params parsing #2553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add some rescues when dealing with rack_params and GET functions Add exceptions related to rescues
dblock requested changes Apr 5, 2025
ericproulx force-pushed the less_parse_nested_query branch from a8c6300 to a872545 Compare ericproulx force-pushed the less_parse_nested_query branch from a872545 to e358a4f Compare dblock approved these changes Apr 6, 2025
| Upgrading Grape | ||
| =============== | ||
| | ||
| ### Grape::Middleware::Base |
There was a problem hiding this comment.
For later, we should have an Upgrading >= X.Y.Z here whatever the next version is.
| Coveralls is down for maintenance, let's wait for it to come back. |
ericproulx added a commit to ericproulx/grape that referenced this pull request Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PRs reduces potential query params parsing. Instead of calling
Rack::Utils.parse_nested_query(env[Rack::QUERY_STRING])directly, Grape will call Rack's function GET that does the same work but keeps the parsed version inRACK_REQUEST_QUERY_HASH. This way, parsing will be done at most once.Also, it fixes #2488 and it comes with a tiny refactor in
Grape::Middleware::Formatterincluding comments in the code. Finally, this PR adds a new function namedrack_requestthat's create a instance ofRack::RequestfromenvinGrape::Middleware::Base.Grape::Middleware::Formatterhad already the equivalent but namedrequest. This helps for callingGETin middlewares and I think user might benefit from it.