Fixed infinitely recursive health checks #3557
Merged
+61 −15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
excitoon force-pushed the fix-eternity-checks branch from d41a87f to 091f880 Compare 
excitoon commented Mar 12, 2025
excitoon force-pushed the fix-eternity-checks branch 5 times, most recently from 637c418 to 6fcc890 Compare excitoon force-pushed the fix-eternity-checks branch from 6fcc890 to a4b4639 Compare | @petyaslavova please review |
Hi @excitoon thank you for your contribution! We’ll review your change soon. |
| Hi Petya, how's your weekend going? 🍻 |
|
|
| @excitoon Tomorrow is the day for this PR review :) |
| The change looks good to me. With it instead of the max recursion depth reached error, an "redis.exceptions.ConnectionError: max number of clients reached" is raised. |
| @petyaslavova Not really, LGTM |
petyaslavova approved these changes Mar 26, 2025
| @petyaslavova Thanks alot!
|
petyaslavova pushed a commit that referenced this pull request Apr 7, 2025
petyaslavova pushed a commit to Kakadus/redis-py that referenced this pull request May 13, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixed infinite recursion in health checks (once and for all).
Fixes #2866
Really fixes #2563