Skip to content

Adapt parsing of FT.PROFILE response #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Adapt parsing of FT.PROFILE response #3242

wants to merge 1 commit into from

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented May 23, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Adapt the parsing of FT.PROFILE response, to match a change done in RediSearch.

Make sure all search related relevant tests are executed both with RESP2 and RESP3.

Remove some custom parsing code that is now unused.
Adapt parsing of FT.PROFILE response
766b92f 
Adapt the parsing of FT.PROFILE response, to match a change done in RediSearch. Make sure all search related relevant tests are executed both with RESP2 and RESP3. Remove some custom parsing code that is now unused.
@gerzse gerzse added maintenance Maintenance (CI, Releases, etc) breakingchange API or Breaking Change labels May 23, 2024
@gerzse gerzse requested a review from vladvildanov May 23, 2024 10:13
@gerzse gerzse marked this pull request as draft June 12, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breakingchange API or Breaking Change maintenance Maintenance (CI, Releases, etc)

1 participant

@gerzse