Fix TFMs missing for ReactiveUI.Testing #4171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… when running on Windows
2 tasks
Contributor
| btw thanks for doing this one. @ChrisPulman I got him to bring in your PR (he originally tried to edit this PR) so you get credit in GitHub for the PR. |
| This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Fixes #4170
What is the current behavior?
ReactiveUI.Testing is missing
net8.0and newer Target FrameworksWhat is the new behavior?
ReactiveUI.Testing is now including the correct target frameworks
What might this PR break?
Please check if the PR fulfills these requirements
Other information:
ReactiveUIFinalModernTargetFrameworks was missing the initial value there was set on the variable and just overwriting it with new values, but only when building on Windows.
I've update the variant that is used with running on windows to include
$(ReactiveUIFinalModernTargetFrameworks)similar to the other definitions.