fix #250: introduce tmpdir option for overriding the system tmp dir #252
+121 −41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
silkentrance force-pushed the gh-250 branch 2 times, most recently from 00877fa to d83dd7b Compare 8 tasks
raszi reviewed Apr 28, 2020
silkentrance force-pushed the gh-250 branch 3 times, most recently from 1494574 to b67f63d Compare 
Collaborator Author
| A new release needs to be made available with an updated version of the changelog. See the instructions in #253 on how to do that. |
Collaborator Author
| @raszi I have already bumped the version and updated the changelog. Have fun releasing 0.2.1 :) |
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix #250: introduce tmpdir option for overriding the system tmp dir
also fix issue with changes to the options leaking out, now copying the options to a new object