Parser can create missing materials #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add an option allowing the parser to auto create missing materials. This supports missing mtl files and references to material names that doesn't exist
greenmoss reviewed Jun 16, 2018
pywavefront/obj.py Outdated
| if self.create_materials: | ||
| self.material = Material(name=name, is_default=True) | ||
| self.wavefront.materials[name] = self.material | ||
| else: |
There was a problem hiding this comment.
Another way to do this:
if not self.create_materials: raise PywavefrontException self.material = Material... This is totally stylistic preference. What do you think?
There was a problem hiding this comment.
It's a bit cleaner I think. Fixing.
| Thanks for the PR @einarf . Please have a look at the comment and let me know what you think. If you have a strong preference to leave it as is, let me know and I can merge as is. |
| Think this should be ready now. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add an option allowing the parser to auto create missing materials. This supports missing mtl files and references to material names that doesn't exist