Skip to content

Conversation

@qqaatw
Copy link
Contributor

@qqaatw qqaatw commented Nov 8, 2024

Summary:

  1. Remove the custom atomic add function and use the one provided by MSL 3.0+ instead.
  2. Use MetalShaderLibrary class.

cc @malfet @kulinseth

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8719

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 16 Unrelated Failures

As of commit 21e09dc with merge base 4249b61 (image):

NEW FAILURES - The following jobs have failed:

  • Docs / build / linux-job (gh)
    RuntimeError: Command docker exec -t e1170bdaeb595e032391d264d8d81aebaacbe3049a9bf3f3d6c5dbcc0654b85e /exec failed with exit code 2
  • Lint / c-source / linux-job (gh)
    RuntimeError: Command docker exec -t ef860c3c4cf75d3eecbe39dee67e5d7040000a96b1ea775daf48a78ecf440992 /exec failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the BE change

@malfet malfet merged commit cb9fdbf into pytorch:main Nov 11, 2024
56 of 84 checks passed
@github-actions
Copy link

Hey @malfet!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Jan 13, 2025
Summary: 1. Remove the custom atomic add function and use the one provided by MSL 3.0+ instead. 2. Use `MetalShaderLibrary` class. Reviewed By: vmoens Differential Revision: D68021975 fbshipit-source-id: 0350d376e0ff3e2ea0e06ce7cacdc33eedfbc84d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment