Skip to content

Removed ImageCmsProfile._set method #9032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

Removed ImageCmsProfile._set method #9032

merged 1 commit into from
Jun 22, 2025

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Jun 22, 2025

This separates part of #8995. I have a question about another part of that PR, so this moves forward a portion of it at least.

#8995

The _set method is no longer necessary, since we no longer compute any attributes from the profile. In most cases, we only set the profile, and in only one branch do we set the filename to anything non-None.
@radarhere @lukegb
Removed ImageCmsProfile._set method
860b87c 
Co-authored-by: Luke Granger-Brown <git@lukegb.com>
@radarhere radarhere mentioned this pull request Jun 22, 2025
Merged
@radarhere radarhere merged commit 2954964 into python-pillow:main Jun 22, 2025
77 of 78 checks passed
@radarhere radarhere deleted the imagecms branch June 22, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup

1 participant

@radarhere