Deprecate ImageCmsProfile product_name and product_info #8995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
radarhere reviewed Jun 3, 2025
Merged
…/product_info The _set method is no longer necessary, since we no longer compute any attributes from the profile. In most cases, we only set the profile, and in only one branch do we set the filename to anything non-None. product_name/product_info were set to None at some point during what appears to be a batch of changes for Python 3 compatibility (ce041fd), and never set back. Given this, let's deprecate these and schedule them for removal in Pillow 13.
radarhere reviewed Jun 4, 2025
radarhere reviewed Jun 4, 2025
docs/deprecations.rst Outdated
| ``ImageCms.ImageCmsProfile.product_name`` and the corresponding | ||
| ``.product_info`` attributes have been deprecated, and will be removed in | ||
| Pillow 13 (2026-10-15). These attributes can be accessed on the ``.profile`` | ||
| attribute of ``ImageCmsProfile`` instead. |
Member
There was a problem hiding this comment.
I'm not following this.
>>> from PIL import ImageCms >>> profile = ImageCms.ImageCmsProfile(ImageCms.createProfile("sRGB")) >>> profile.profile.product_name Traceback (most recent call last): File "<stdin>", line 1, in <module> AttributeError: 'PIL.ImageCms.core.CmsProfile' object has no attribute 'product_name' Member
There was a problem hiding this comment.
I've pushed commits to remove the replacement suggestion.
Member
This is an undocumented underscore method, so not part of the public API and can be changed/removed without deprecation. https://pillow.readthedocs.io/en/stable/reference/ImageCms.html |
radarhere force-pushed the imagecms-typing branch from 7629c2e to 7713df9 Compare 
Member
| I've created #9032, to move forward with part of this at least. |
radarhere force-pushed the imagecms-typing branch from dabb506 to 97cd599 Compare radarhere force-pushed the imagecms-typing branch from 1598ce8 to f6df21b Compare radarhere reviewed Jul 9, 2025
radarhere reviewed Jul 13, 2025
radarhere reviewed Jul 13, 2025
radarhere force-pushed the imagecms-typing branch from 01e0b00 to 8383b72 Compare radarhere reviewed Jul 22, 2025
radarhere approved these changes Jul 23, 2025
radarhere changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The _set method is no longer necessary, since we no longer compute any attributes from the profile. In most cases, we only set the profile, and in only one branch do we set the filename to anything non-None.
product_name/product_info were set to None at some point during what appears to be a batch of changes for Python 3 compatibility (ce041fd), and never set back. Given this, let's deprecate these and schedule them for removal in Pillow 13.
Changes proposed in this pull request: