Allow last_translator to be passed as an option to extract_message #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
akx requested changes Nov 27, 2023
tests/messages/test_frontend.py Outdated
| def test_extract_cli_knows_dash_dash_last_dash_translator(): | ||
| cmdinst = configure_cli_command("extract --last-translator e-mail -o foo babel") | ||
| assert isinstance(cmdinst, ExtractMessages) | ||
| assert cmdinst.last_translator |
Member
There was a problem hiding this comment.
This should presumably check that it was assigned to e-mail?
Contributor Author
There was a problem hiding this comment.
Sure you are right. Actually it can be not only an e-mail, fixed.
babel/messages/frontend.py Outdated
| 'Separate multiple patterns with spaces (default ".* ._")'), | ||
| ('header-comment=', None, | ||
| 'header comment for the catalog'), | ||
| ('last-translator=', 'T', |
Member
There was a problem hiding this comment.
Maybe skip the shortname?
Suggested change
| ('last-translator=', 'T', | |
| ('last-translator=', None, |
Contributor Author
There was a problem hiding this comment.
I'm good with that. Changed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #1044 +/- ## ======================================= Coverage 91.34% 91.34% ======================================= Files 26 26 Lines 4415 4416 +1 ======================================= + Hits 4033 4034 +1 Misses 382 382 ☔ View full report in Codecov by Sentry. |
koldakov force-pushed the feature/propagate-last-translator branch from 4f6b2bb to fa0fe87 Compare 
akx force-pushed the feature/propagate-last-translator branch from fa0fe87 to 2126403 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Commit allows to pass last translator to the CLI.
For example,
pybabel extract --last-translator=test@test.test