Add default filterwarning configuration #696
Merged
+499 −48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ionelmc changed the title 
| if TYPE_CHECKING: | ||
| from .engine import CovController | ||
| | ||
| COVERAGE_SQLITE_WARNING_RE = re.compile('unclosed database in <sqlite3.Connection object at', re.I) |
There was a problem hiding this comment.
LGTM; with conditions:
NIT - the pattern string could have be abstracted for use later
Suggested change
| COVERAGE_SQLITE_WARNING_RE = re.compile('unclosed database in <sqlite3.Connection object at', re.I) | |
| COVERAGE_SQLITE_WARNING_STUB = 'unclosed database in <sqlite3.Connection object at' | |
| COVERAGE_SQLITE_WARNING_RE = re.compile(COVERAGE_SQLITE_WARNING_STUB, re.I) |
and later used to simplify:
for _, message, category, _, _ in warnings.filters: if category is ResourceWarning and message == COVERAGE_SQLITE_WARNING_RE: break else: warnings.filterwarnings('default', 'unclosed database in <sqlite3.Connection object at', ResourceWarning)with the patch:
for _, message, category, _, _ in warnings.filters: if category is ResourceWarning and message == COVERAGE_SQLITE_WARNING_RE: break else: - warnings.filterwarnings('default', 'unclosed database in <sqlite3.Connection object at', ResourceWarning) + warnings.filterwarnings('default', COVERAGE_SQLITE_WARNING_STUB, ResourceWarning)yielding:
for _, message, category, _, _ in warnings.filters: if category is ResourceWarning and message == COVERAGE_SQLITE_WARNING_RE: break else: warnings.filterwarnings('default', COVERAGE_SQLITE_WARNING_STUB, ResourceWarning)| if category is ResourceWarning and message == COVERAGE_SQLITE_WARNING_RE: | ||
| break | ||
| else: | ||
| warnings.filterwarnings('default', 'unclosed database in <sqlite3.Connection object at', ResourceWarning) |
There was a problem hiding this comment.
LGTM; with continued conditions:
NIT - Could be more DRY
As mentioned already, this string could be set with the RE variable so that only the base string need be ever updated 🤷
e.g.,
COVERAGE_SQLITE_WARNING_STUB = 'unclosed database in <sqlite3.Connection object at' COVERAGE_SQLITE_WARNING_RE = re.compile(COVERAGE_SQLITE_WARNING_STUB, re.I)and refactor this line to:
Suggested change
| warnings.filterwarnings('default', 'unclosed database in <sqlite3.Connection object at', ResourceWarning) | |
| warnings.filterwarnings('default', COVERAGE_SQLITE_WARNING_STUB, ResourceWarning) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.