Correct assert usage in interface test #2871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@ ## main #2871 +/- ## ======================================= Coverage 93.34% 93.34% ======================================= Files 92 92 Lines 11194 11194 ======================================= Hits 10449 10449 Misses 745 745
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Pierre-Sassoulas approved these changes Oct 22, 2025
Pierre-Sassoulas temporarily deployed to Backport 
GitHub Actions Inactive Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This PR fixes minor assertion misuse in the inference tests - Some
assertTruecalls were incorrectly passingTrueas a second argument (interpreted as a message rather than a value). Just something I noticed while working on another fix - uploading it now so I don’t forget.