Remove hover striping from all but .dataframe tables #2059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
| To test this, compare the tables at the following URLs. These should not have a purple background on hover: Whereas these should have a purple background on hover: |
trallard approved these changes Nov 29, 2024
trallard added tag: accessibility drammock pushed a commit that referenced this pull request Dec 3, 2024
This pull request: - changes the background hover color on tables to improve legibility - differs from the [design system](https://www.figma.com/design/SnLFWtSKEBLYrtLHbs4TSE/PyData-Sphinx-Theme-Design-System-(Community)?node-id=3312-493), but I think it looks better, plus it steps up the hover background/foreground contrast in light mode to meet WCAG AAA. Note: once #2059 is merged, this will only affect `.dataframe` classes ### After screenshot   ### Before screenshot  
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #1894.