Use the globals of the function when evaluating the return type of serializers and computed_fields #10929
Conversation
…rializers and computed_fields
Deploying pydantic-docs with |
| Latest commit: | 821184f |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2cc7b3e8.pydantic-docs.pages.dev |
| Branch Preview URL: | https://func-rt.pydantic-docs.pages.dev |
| @pytest.mark.xfail( | ||
| reason='In `GenerateSchema`, only the current class module is taken into account. ' | ||
| 'This is similar to `test_uses_the_correct_globals_to_resolve_model_forward_refs`.' | ||
| ) |
There was a problem hiding this comment.
Turns out this used to work. However, the mentioned test_uses_the_correct_globals_to_resolve_model_forward_refs test was also failing on 2.9
| @create_module | ||
| def module_1(): | ||
| from pydantic import BaseModel, field_serializer # or model_serializer | ||
| from pydantic import BaseModel, field_serializer # or model_serializer, computed_field |
There was a problem hiding this comment.
| from pydantic import BaseModel, field_serializer # or model_serializer, computed_field | |
| from pydantic import BaseModel, field_serializer # or model_serializer |
There was a problem hiding this comment.
The goal was to mentioned that this also applied to computed_field
There was a problem hiding this comment.
Right, but it's not included in the example?
There was a problem hiding this comment.
It is commented out, just to mention that the same logic applies to the three decorators. We could add a test for each alternatively.
There was a problem hiding this comment.
oh my goodness 😢 sorry I missed that 🫨. Thanks! Let's merge :)
| Looking good, I'm guessing there are changes to |
CodSpeed Performance ReportMerging #10929 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action | ||||||||||||||||||||||||
-007ec6.svg "This PR adds 1195 statements to pydantic/_internal/_generate_schema.py. The file did not seem to exist on the base branch."){kind=icon}
-red.svg "This PR adds 39 statements missing coverage to pydantic/_internal/_generate_schema.py. The file did not seem to exist on the base branch."){kind=icon}
-orange.svg "The coverage rate of pydantic/_internal/_generate_schema.py is 95.81% (1156/1195). The file did not seem to exist on the base branch."){kind=icon}
-brightgreen.svg "In this PR, 1 new statements are added to pydantic/_internal/_generate_schema.py, 1 of which are covered (100%)."){kind=icon}
-007ec6.svg "This PR adds 9925 statements to the whole project. The file did not seem to exist on the base branch."){kind=icon}
-red.svg "This PR adds 317 statements missing coverage to the whole project. The file did not seem to exist on the base branch."){kind=icon}
-orange.svg "The coverage rate of the whole project is 95.67% (9608/9925). The file did not seem to exist on the base branch."){kind=icon}
Not passing any globals will let |
…serializers and computed_fields (#10929)
2 participants
Fixes #10919
Change Summary
Related issue number
Checklist