Remove typed_dict_cls data from CoreMetadata #10180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Deploying pydantic-docs with |
| Latest commit: | c3db3ef |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6bb8cff1.pydantic-docs.pages.dev |
| Branch Preview URL: | https://move-to-schema.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10180 will not alter performanceComparing Summary
|
adriangb approved these changes Aug 19, 2024
sydney-runkle added relnotes-change 
Coverage report
This PR does not seem to contain any modification to coverable code. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A companion PR to pydantic/pydantic-core#1410 (we'll have to wait on a release with said change)
The idea here: move away from storing information used for JSON schema generation in the catchall
metadataattribute, and instead explicitly store it on the core schema itself.Also, we already store
clsfor dataclasses and models, so this makes things more consistent overall.