feat(blockdevice): added sysblockdevicesize method and test #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2024
Contributor Author
| fixed DCO and tests with this new PR cc @dswarbrick |
| Hi @discordianfish, would it be possible to get your review on this PR? Thanks. |
discordianfish approved these changes Sep 22, 2024
Member
discordianfish left a comment
discordianfish left a comment There was a problem hiding this comment.
LGtM in general though
fs185143 force-pushed the block-device-size branch 2 times, most recently from c4644b4 to efdaa11 Compare 
dswarbrick approved these changes Oct 2, 2024
Contributor Author
| @discordianfish mind taking another look at this please? thanks 😄 |
discordianfish approved these changes Oct 30, 2024
Contributor Author
| @discordianfish thanks :) didn't seem to get merged automatically? I merged master in in case that was the issue, but now says a workflow is awaiting approval. |
Member
| @SuperQ needs to review this first |
Contributor Author
| @SuperQ mind taking a look please? |
Member
| Would you please rebase this PR, it seems like the git history is corrupted. |
Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: fs185143 <fs185143@ncr.com>
fs185143 force-pushed the block-device-size branch from 83bae4a to a4338f4 Compare Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: fs185143 <fs185143@ncr.com>
fs185143 force-pushed the block-device-size branch from a4338f4 to 6c3ef0b Compare Signed-off-by: Finn Snape <145353420+fs185143@users.noreply.github.com>
Contributor Author
done |
Contributor Author
| @SuperQ is there anything else that needs to be done to merge this on my side? |
Member
| Looks great, thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In part to support prometheus/node_exporter#3068, I have added a new method that retrieves the value of
/sys/block/<device>/size