Expose secret as SecretReader and InlineSecret from config package #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
4 tasks
gotjosh approved these changes Jun 7, 2024
Member
gotjosh left a comment
gotjosh left a comment There was a problem hiding this comment.
LGTM
I checked and we don't have SecretReader nor InlineSecret in Prometheus so the names LGTM.
Member
| @SuperQ @ArthurSens any objections? |
Member
| I'm going to proceed with the merge as exposing things public is most of the time uncontroversial, but do let me know if there's anything that needs addressing. I've checked Prometheus and the Alertmanger - and these aren't conflicting. |
Contributor
| Nice! this was also breaking Thanos: #538 (comment) |
Contributor
| Actually thanos also need the FileSecret to be exposed: =/ |
yurishkuro referenced this pull request in jaegertracing/jaeger Jun 26, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.54.0` -> `v0.55.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.55.0`](https://togithub.com/prometheus/common/releases/tag/v0.55.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.54.0...v0.55.0) #### What's Changed - Update Go modules by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/643](https://togithub.com/prometheus/common/pull/643) - enable errcheck linter by [@​mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/prometheus/common/pull/637](https://togithub.com/prometheus/common/pull/637) - Add a `RELEASE.md` and add [@​gotjosh](https://togithub.com/gotjosh) as a mantainer by [@​gotjosh](https://togithub.com/gotjosh) in [https://github.com/prometheus/common/pull/644](https://togithub.com/prometheus/common/pull/644) - Move goautoneg to external dependency by [@​mikelolasagasti](https://togithub.com/mikelolasagasti) in [https://github.com/prometheus/common/pull/625](https://togithub.com/prometheus/common/pull/625) - Expose secret as SecretReader and InlineSecret from config package by [@​pracucci](https://togithub.com/pracucci) in [https://github.com/prometheus/common/pull/650](https://togithub.com/prometheus/common/pull/650) - Fix HTTPClientConfig JSON marshalling by [@​pracucci](https://togithub.com/pracucci) in [https://github.com/prometheus/common/pull/651](https://togithub.com/prometheus/common/pull/651) - Expose secret as FileSecret from config package by [@​alanprot](https://togithub.com/alanprot) in [https://github.com/prometheus/common/pull/653](https://togithub.com/prometheus/common/pull/653) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/646](https://togithub.com/prometheus/common/pull/646) - Set http_headers to be omit empty by [@​yeya24](https://togithub.com/yeya24) in [https://github.com/prometheus/common/pull/655](https://togithub.com/prometheus/common/pull/655) - chore: add HumanizeTimestamp; make ConvertToFloat exportable by [@​freak12techno](https://togithub.com/freak12techno) in [https://github.com/prometheus/common/pull/654](https://togithub.com/prometheus/common/pull/654) - Bump github.com/aws/aws-sdk-go from 1.53.14 to 1.54.7 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/659](https://togithub.com/prometheus/common/pull/659) - Bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/656](https://togithub.com/prometheus/common/pull/656) - Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/658](https://togithub.com/prometheus/common/pull/658) - Bump golang.org/x/net from 0.25.0 to 0.26.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/657](https://togithub.com/prometheus/common/pull/657) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/660](https://togithub.com/prometheus/common/pull/660) - Add SigV4 FIPS STS endpoint config by [@​rajagopalanand](https://togithub.com/rajagopalanand) in [https://github.com/prometheus/common/pull/649](https://togithub.com/prometheus/common/pull/649) #### New Contributors - [@​gotjosh](https://togithub.com/gotjosh) made their first contribution in [https://github.com/prometheus/common/pull/644](https://togithub.com/prometheus/common/pull/644) - [@​mikelolasagasti](https://togithub.com/mikelolasagasti) made their first contribution in [https://github.com/prometheus/common/pull/625](https://togithub.com/prometheus/common/pull/625) - [@​alanprot](https://togithub.com/alanprot) made their first contribution in [https://github.com/prometheus/common/pull/653](https://togithub.com/prometheus/common/pull/653) - [@​yeya24](https://togithub.com/yeya24) made their first contribution in [https://github.com/prometheus/common/pull/655](https://togithub.com/prometheus/common/pull/655) - [@​rajagopalanand](https://togithub.com/rajagopalanand) made their first contribution in [https://github.com/prometheus/common/pull/649](https://togithub.com/prometheus/common/pull/649) **Full Changelog**: prometheus/common@v0.54.0...v0.55.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jaegertracing/jaeger). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJjaGFuZ2Vsb2c6ZGVwZW5kZW5jaWVzIl19--> --------- Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <github@ysh.us>
MrAlias referenced this pull request in open-telemetry/opentelemetry-go-contrib Jun 26, 2024
…5806) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.54.0` -> `v0.55.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.55.0`](https://togithub.com/prometheus/common/releases/tag/v0.55.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.54.0...v0.55.0) #### What's Changed - Update Go modules by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/643](https://togithub.com/prometheus/common/pull/643) - enable errcheck linter by [@​mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/prometheus/common/pull/637](https://togithub.com/prometheus/common/pull/637) - Add a `RELEASE.md` and add [@​gotjosh](https://togithub.com/gotjosh) as a mantainer by [@​gotjosh](https://togithub.com/gotjosh) in [https://github.com/prometheus/common/pull/644](https://togithub.com/prometheus/common/pull/644) - Move goautoneg to external dependency by [@​mikelolasagasti](https://togithub.com/mikelolasagasti) in [https://github.com/prometheus/common/pull/625](https://togithub.com/prometheus/common/pull/625) - Expose secret as SecretReader and InlineSecret from config package by [@​pracucci](https://togithub.com/pracucci) in [https://github.com/prometheus/common/pull/650](https://togithub.com/prometheus/common/pull/650) - Fix HTTPClientConfig JSON marshalling by [@​pracucci](https://togithub.com/pracucci) in [https://github.com/prometheus/common/pull/651](https://togithub.com/prometheus/common/pull/651) - Expose secret as FileSecret from config package by [@​alanprot](https://togithub.com/alanprot) in [https://github.com/prometheus/common/pull/653](https://togithub.com/prometheus/common/pull/653) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/646](https://togithub.com/prometheus/common/pull/646) - Set http_headers to be omit empty by [@​yeya24](https://togithub.com/yeya24) in [https://github.com/prometheus/common/pull/655](https://togithub.com/prometheus/common/pull/655) - chore: add HumanizeTimestamp; make ConvertToFloat exportable by [@​freak12techno](https://togithub.com/freak12techno) in [https://github.com/prometheus/common/pull/654](https://togithub.com/prometheus/common/pull/654) - Bump github.com/aws/aws-sdk-go from 1.53.14 to 1.54.7 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/659](https://togithub.com/prometheus/common/pull/659) - Bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/656](https://togithub.com/prometheus/common/pull/656) - Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/658](https://togithub.com/prometheus/common/pull/658) - Bump golang.org/x/net from 0.25.0 to 0.26.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/657](https://togithub.com/prometheus/common/pull/657) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/660](https://togithub.com/prometheus/common/pull/660) - Add SigV4 FIPS STS endpoint config by [@​rajagopalanand](https://togithub.com/rajagopalanand) in [https://github.com/prometheus/common/pull/649](https://togithub.com/prometheus/common/pull/649) #### New Contributors - [@​gotjosh](https://togithub.com/gotjosh) made their first contribution in [https://github.com/prometheus/common/pull/644](https://togithub.com/prometheus/common/pull/644) - [@​mikelolasagasti](https://togithub.com/mikelolasagasti) made their first contribution in [https://github.com/prometheus/common/pull/625](https://togithub.com/prometheus/common/pull/625) - [@​alanprot](https://togithub.com/alanprot) made their first contribution in [https://github.com/prometheus/common/pull/653](https://togithub.com/prometheus/common/pull/653) - [@​yeya24](https://togithub.com/yeya24) made their first contribution in [https://github.com/prometheus/common/pull/655](https://togithub.com/prometheus/common/pull/655) - [@​rajagopalanand](https://togithub.com/rajagopalanand) made their first contribution in [https://github.com/prometheus/common/pull/649](https://togithub.com/prometheus/common/pull/649) **Full Changelog**: prometheus/common@v0.54.0...v0.55.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
MrAlias referenced this pull request in open-telemetry/opentelemetry-go Jun 26, 2024
…5552) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.54.0` -> `v0.55.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.55.0`](https://togithub.com/prometheus/common/releases/tag/v0.55.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.54.0...v0.55.0) #### What's Changed - Update Go modules by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/643](https://togithub.com/prometheus/common/pull/643) - enable errcheck linter by [@​mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/prometheus/common/pull/637](https://togithub.com/prometheus/common/pull/637) - Add a `RELEASE.md` and add [@​gotjosh](https://togithub.com/gotjosh) as a mantainer by [@​gotjosh](https://togithub.com/gotjosh) in [https://github.com/prometheus/common/pull/644](https://togithub.com/prometheus/common/pull/644) - Move goautoneg to external dependency by [@​mikelolasagasti](https://togithub.com/mikelolasagasti) in [https://github.com/prometheus/common/pull/625](https://togithub.com/prometheus/common/pull/625) - Expose secret as SecretReader and InlineSecret from config package by [@​pracucci](https://togithub.com/pracucci) in [https://github.com/prometheus/common/pull/650](https://togithub.com/prometheus/common/pull/650) - Fix HTTPClientConfig JSON marshalling by [@​pracucci](https://togithub.com/pracucci) in [https://github.com/prometheus/common/pull/651](https://togithub.com/prometheus/common/pull/651) - Expose secret as FileSecret from config package by [@​alanprot](https://togithub.com/alanprot) in [https://github.com/prometheus/common/pull/653](https://togithub.com/prometheus/common/pull/653) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/646](https://togithub.com/prometheus/common/pull/646) - Set http_headers to be omit empty by [@​yeya24](https://togithub.com/yeya24) in [https://github.com/prometheus/common/pull/655](https://togithub.com/prometheus/common/pull/655) - chore: add HumanizeTimestamp; make ConvertToFloat exportable by [@​freak12techno](https://togithub.com/freak12techno) in [https://github.com/prometheus/common/pull/654](https://togithub.com/prometheus/common/pull/654) - Bump github.com/aws/aws-sdk-go from 1.53.14 to 1.54.7 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/659](https://togithub.com/prometheus/common/pull/659) - Bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/656](https://togithub.com/prometheus/common/pull/656) - Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/658](https://togithub.com/prometheus/common/pull/658) - Bump golang.org/x/net from 0.25.0 to 0.26.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/657](https://togithub.com/prometheus/common/pull/657) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/660](https://togithub.com/prometheus/common/pull/660) - Add SigV4 FIPS STS endpoint config by [@​rajagopalanand](https://togithub.com/rajagopalanand) in [https://github.com/prometheus/common/pull/649](https://togithub.com/prometheus/common/pull/649) #### New Contributors - [@​gotjosh](https://togithub.com/gotjosh) made their first contribution in [https://github.com/prometheus/common/pull/644](https://togithub.com/prometheus/common/pull/644) - [@​mikelolasagasti](https://togithub.com/mikelolasagasti) made their first contribution in [https://github.com/prometheus/common/pull/625](https://togithub.com/prometheus/common/pull/625) - [@​alanprot](https://togithub.com/alanprot) made their first contribution in [https://github.com/prometheus/common/pull/653](https://togithub.com/prometheus/common/pull/653) - [@​yeya24](https://togithub.com/yeya24) made their first contribution in [https://github.com/prometheus/common/pull/655](https://togithub.com/prometheus/common/pull/655) - [@​rajagopalanand](https://togithub.com/rajagopalanand) made their first contribution in [https://github.com/prometheus/common/pull/649](https://togithub.com/prometheus/common/pull/649) **Full Changelog**: prometheus/common@v0.54.0...v0.55.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mx-psi referenced this pull request in open-telemetry/opentelemetry-collector-contrib Jul 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.54.0` -> `v0.55.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.55.0`](https://togithub.com/prometheus/common/releases/tag/v0.55.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.54.0...v0.55.0) #### What's Changed - Update Go modules by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/643](https://togithub.com/prometheus/common/pull/643) - enable errcheck linter by [@​mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/prometheus/common/pull/637](https://togithub.com/prometheus/common/pull/637) - Add a `RELEASE.md` and add [@​gotjosh](https://togithub.com/gotjosh) as a mantainer by [@​gotjosh](https://togithub.com/gotjosh) in [https://github.com/prometheus/common/pull/644](https://togithub.com/prometheus/common/pull/644) - Move goautoneg to external dependency by [@​mikelolasagasti](https://togithub.com/mikelolasagasti) in [https://github.com/prometheus/common/pull/625](https://togithub.com/prometheus/common/pull/625) - Expose secret as SecretReader and InlineSecret from config package by [@​pracucci](https://togithub.com/pracucci) in [https://github.com/prometheus/common/pull/650](https://togithub.com/prometheus/common/pull/650) - Fix HTTPClientConfig JSON marshalling by [@​pracucci](https://togithub.com/pracucci) in [https://github.com/prometheus/common/pull/651](https://togithub.com/prometheus/common/pull/651) - Expose secret as FileSecret from config package by [@​alanprot](https://togithub.com/alanprot) in [https://github.com/prometheus/common/pull/653](https://togithub.com/prometheus/common/pull/653) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/646](https://togithub.com/prometheus/common/pull/646) - Set http_headers to be omit empty by [@​yeya24](https://togithub.com/yeya24) in [https://github.com/prometheus/common/pull/655](https://togithub.com/prometheus/common/pull/655) - chore: add HumanizeTimestamp; make ConvertToFloat exportable by [@​freak12techno](https://togithub.com/freak12techno) in [https://github.com/prometheus/common/pull/654](https://togithub.com/prometheus/common/pull/654) - Bump github.com/aws/aws-sdk-go from 1.53.14 to 1.54.7 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/659](https://togithub.com/prometheus/common/pull/659) - Bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/656](https://togithub.com/prometheus/common/pull/656) - Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/658](https://togithub.com/prometheus/common/pull/658) - Bump golang.org/x/net from 0.25.0 to 0.26.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/657](https://togithub.com/prometheus/common/pull/657) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/660](https://togithub.com/prometheus/common/pull/660) - Add SigV4 FIPS STS endpoint config by [@​rajagopalanand](https://togithub.com/rajagopalanand) in [https://github.com/prometheus/common/pull/649](https://togithub.com/prometheus/common/pull/649) #### New Contributors - [@​gotjosh](https://togithub.com/gotjosh) made their first contribution in [https://github.com/prometheus/common/pull/644](https://togithub.com/prometheus/common/pull/644) - [@​mikelolasagasti](https://togithub.com/mikelolasagasti) made their first contribution in [https://github.com/prometheus/common/pull/625](https://togithub.com/prometheus/common/pull/625) - [@​alanprot](https://togithub.com/alanprot) made their first contribution in [https://github.com/prometheus/common/pull/653](https://togithub.com/prometheus/common/pull/653) - [@​yeya24](https://togithub.com/yeya24) made their first contribution in [https://github.com/prometheus/common/pull/655](https://togithub.com/prometheus/common/pull/655) - [@​rajagopalanand](https://togithub.com/rajagopalanand) made their first contribution in [https://github.com/prometheus/common/pull/649](https://togithub.com/prometheus/common/pull/649) **Full Changelog**: prometheus/common@v0.54.0...v0.55.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
mx-psi referenced this pull request in open-telemetry/opentelemetry-collector Jul 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.54.0` -> `v0.55.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.55.0`](https://togithub.com/prometheus/common/releases/tag/v0.55.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.54.0...v0.55.0) ##### What's Changed - Update Go modules by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/common/pull/643](https://togithub.com/prometheus/common/pull/643) - enable errcheck linter by [@​mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/prometheus/common/pull/637](https://togithub.com/prometheus/common/pull/637) - Add a `RELEASE.md` and add [@​gotjosh](https://togithub.com/gotjosh) as a mantainer by [@​gotjosh](https://togithub.com/gotjosh) in [https://github.com/prometheus/common/pull/644](https://togithub.com/prometheus/common/pull/644) - Move goautoneg to external dependency by [@​mikelolasagasti](https://togithub.com/mikelolasagasti) in [https://github.com/prometheus/common/pull/625](https://togithub.com/prometheus/common/pull/625) - Expose secret as SecretReader and InlineSecret from config package by [@​pracucci](https://togithub.com/pracucci) in [https://github.com/prometheus/common/pull/650](https://togithub.com/prometheus/common/pull/650) - Fix HTTPClientConfig JSON marshalling by [@​pracucci](https://togithub.com/pracucci) in [https://github.com/prometheus/common/pull/651](https://togithub.com/prometheus/common/pull/651) - Expose secret as FileSecret from config package by [@​alanprot](https://togithub.com/alanprot) in [https://github.com/prometheus/common/pull/653](https://togithub.com/prometheus/common/pull/653) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/646](https://togithub.com/prometheus/common/pull/646) - Set http_headers to be omit empty by [@​yeya24](https://togithub.com/yeya24) in [https://github.com/prometheus/common/pull/655](https://togithub.com/prometheus/common/pull/655) - chore: add HumanizeTimestamp; make ConvertToFloat exportable by [@​freak12techno](https://togithub.com/freak12techno) in [https://github.com/prometheus/common/pull/654](https://togithub.com/prometheus/common/pull/654) - Bump github.com/aws/aws-sdk-go from 1.53.14 to 1.54.7 in /sigv4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/659](https://togithub.com/prometheus/common/pull/659) - Bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/656](https://togithub.com/prometheus/common/pull/656) - Bump google.golang.org/protobuf from 1.34.1 to 1.34.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/658](https://togithub.com/prometheus/common/pull/658) - Bump golang.org/x/net from 0.25.0 to 0.26.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/prometheus/common/pull/657](https://togithub.com/prometheus/common/pull/657) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/common/pull/660](https://togithub.com/prometheus/common/pull/660) - Add SigV4 FIPS STS endpoint config by [@​rajagopalanand](https://togithub.com/rajagopalanand) in [https://github.com/prometheus/common/pull/649](https://togithub.com/prometheus/common/pull/649) ##### New Contributors - [@​gotjosh](https://togithub.com/gotjosh) made their first contribution in [https://github.com/prometheus/common/pull/644](https://togithub.com/prometheus/common/pull/644) - [@​mikelolasagasti](https://togithub.com/mikelolasagasti) made their first contribution in [https://github.com/prometheus/common/pull/625](https://togithub.com/prometheus/common/pull/625) - [@​alanprot](https://togithub.com/alanprot) made their first contribution in [https://github.com/prometheus/common/pull/653](https://togithub.com/prometheus/common/pull/653) - [@​yeya24](https://togithub.com/yeya24) made their first contribution in [https://github.com/prometheus/common/pull/655](https://togithub.com/prometheus/common/pull/655) - [@​rajagopalanand](https://togithub.com/rajagopalanand) made their first contribution in [https://github.com/prometheus/common/pull/649](https://togithub.com/prometheus/common/pull/649) **Full Changelog**: prometheus/common@v0.54.0...v0.55.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Member
| Thanks for fixing! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#572 broke the vendoring in Mimir, where we have an use case calling
NewBasicAuthRoundTripper(). The problem is that thesecretinterface is private, but it's used in publicly exposed functions likeNewBasicAuthRoundTripper().In this PR I propose to expose
secretasSecretReader(we already havetype Secret string) and to also exposeInlineSecretgiven passing a const secret is a common use case.