Skip to content

feat: Add more fields incl sender to Parcel #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add more fields incl sender to Parcel #47

wants to merge 2 commits into from

Conversation

@AlexLamond
Copy link

@AlexLamond AlexLamond commented Apr 19, 2023 •
edited
Loading

minor:

  • Changes the ordering of @property declarations to match the ordering on the Sendcloud API documentation

feat:

  • Adds sender_* fields
  • Adds collo fields
  • Adds Deutsche Post fields
  • Adds customs fields (EORI, VAT)

break:

  • Replaces requestShipment with request_label as is the format in the Sendcloud API
@casperbakker
Copy link
Member

Replaces requestShipment with request_label as is the format in the Sendcloud API

I think there is no need to make this breaking backwards compatibility. It is fine to have a new standard, but can we make the old parameter work as well? That way no code that is in use today would break.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@AlexLamond @casperbakker