Fix lowercase string usage in template #4122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
VincentLanglet force-pushed the fix/generic-lowercase-string branch 2 times, most recently from d95ae63 to b4eff06 Compare 
staabm reviewed Jul 20, 2025
| } | ||
| | ||
| /** | ||
| * @extends ScalarType<lowercase-string> |
There was a problem hiding this comment.
Does the fix also affect other string types, which should be tested here?
There was a problem hiding this comment.
Yes, uppercaseString.
I added a test.
| There's a conflict, please fix it. Thank you for the fix. This API is not used often enough for me to be able to come up with a better design, most places use |
staabm approved these changes Jul 21, 2025
VincentLanglet force-pushed the fix/generic-lowercase-string branch from f8edc8c to 7e9cb46 Compare 
| Thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#12739
Seems like the issue is related to the fact that
ScalarType<string>andScalarType<lowercase-string>had the same cacheKey or something like that.AccessoryLowercaseStringTypeandAccessoryUppercaseStringTypewas lost forlevel::cachebecause the check was onlyisPrecise.So I added
$level->isCache()and updated every$level->isPrecise()checks (with tests).But I dunno if it's not better to do something like
(And eventually rename the method to
isAtLeastPrecise? Your call @ondrejmirtes.