Skip to content

Fix IntersectionType::isIterableOnce #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2025
Merged

Fix IntersectionType::isIterableOnce #4106

merged 2 commits into from
Jul 21, 2025

Conversation

@VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Jul 17, 2025 •
edited
Loading

Closes phpstan/phpstan#13248

I feel like non-iterable should be excluded since as soon as one subtype is iterable the whole intersection is iterable.
ondrejmirtes
ondrejmirtes requested changes Jul 21, 2025
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you.
@ondrejmirtes
Copy link
Member

Also, there might be more candidates to also use a filter in IntersectionType: hasOffsetValueType/getOffsetValueTypesetOffsetValueType (should use isOffsetAccessible)

Feel free to explore that with a failing test in a separate PR. Thank you!
@ondrejmirtes
Copy link
Member

But maybe not because ObjectType::isOffsetAccessible() says "maybe" for non-final classes which is correct.
@ondrejmirtes ondrejmirtes merged commit 2b9e658 into phpstan:2.1.x Jul 21, 2025
241 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@VincentLanglet @ondrejmirtes