5x Faster IntersectionType->getEnumCases() #3695
Merged
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
staabm changed the title IntersectionType-> getEnumCases()IntersectionType->getEnumCases() 
staabm commented Nov 30, 2024
| $oneType = []; | ||
| foreach ($type->getEnumCases() as $enumCase) { | ||
| $oneType[md5($enumCase->describe(VerbosityLevel::typeOnly()))] = $enumCase; | ||
| $oneType[$enumCase->getClassName() . '::' . $enumCase->getEnumCaseName()] = $enumCase; |
There was a problem hiding this comment.
I think since we only handle enum case objects here, which are always final, we should be able to take this shortcut
| This pull request has been marked as ready for review. |
| Thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
refs phpstan/phpstan#11968
using a reduced repro
before this PR
after this PR
the full repro of phpstan/phpstan#11968 takes still 11,5 seconds after this PR on my m4 pro (took 1min10s before)