Skip to content

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet changed the base branch from 1.12.x to 1.11.x August 11, 2024 00:36
@phpstan-bot
Copy link
Collaborator

You've opened the pull request against the latest branch 1.12.x. If your code is relevant on 1.11.x and you want it to be released sooner, please rebase your pull request and change its target to 1.11.x.

@ondrejmirtes
Copy link
Member

This fixes phpstan/phpstan#9659 too, please add a regression test.

@VincentLanglet
Copy link
Contributor Author

This fixes phpstan/phpstan#9659 too, please add a regression test.

Done.

BTW, I do you know which issue it will solve. I assume you had a CI for this ?

@staabm
Copy link
Contributor

staabm commented Aug 11, 2024

You can see it in the issue-bot job summary

https://github.com/phpstan/phpstan-src/actions/runs/10338705040

@ondrejmirtes ondrejmirtes merged commit 6c2edd5 into phpstan:1.11.x Aug 12, 2024
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants