RegularExpressionPatternRule: validate preg_quote'd patterns #3270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
staabm changed the title 
| This pull request has been marked as ready for review. |
| Thank you. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
similar to how we added support for preg_quote'd patterns in ArrayShapeMatcher, we now re-use the logic in RegularExpressionPatternRule
Review at best commit by commit
commit 1: refactoring of ArrayShapeMatcher for re-use
commit 2: adjust RegularExpressionPatternRule to make use of the refactoring