Regex parsing fixes for newline characters and marker verbs #3268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| You've opened the pull request against the latest branch 1.12.x. If your code is relevant on 1.11.x and you want it to be released sooner, please rebase your pull request and change its target to 1.11.x. |
mvorisek reviewed Jul 25, 2024
staabm reviewed Jul 26, 2024
staabm reviewed Jul 26, 2024
| assertType('array{string, non-empty-string, non-empty-string, non-empty-string}', $matches); | ||
| } | ||
| if (preg_match('/foo(*:first)|bar(*:second)([x])/', $s, $matches)) { | ||
| assertType("array{0: string, 1?: non-empty-string, MARK?: 'first'|'second'}", $matches); |
There was a problem hiding this comment.
should MARK be non-optional since we are sure here about the successfull match?
(in other words: should it be optional/non-optional depending on $wasMatched (or other alternation rules)?
There was a problem hiding this comment.
I left it as such because it depends where the mark is https://3v4l.org/vJofm - and it seems to me not really worth the effort to ensure whether it's in a match group that is optional or not, given how niche this feature is.
| Thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
cc @staabm @mvorisek