ExponentiateHelper: fix internal error and internal warning #3031
Conversation
| $result = $base->getValue() ** $exponent->getValue(); | ||
| try { | ||
| // @ to avoid "Warning: A non-numeric value encountered" | ||
| $result = @pow($base->getValue(), $exponent->getValue()); // @phpstan-ignore-line |
There was a problem hiding this comment.
I'd rather prevent the problem by checking the type of the values instead of silencing the error.
There was a problem hiding this comment.
That would require some crazy regexes. I dont think there is a simple way to simulate the magical numeric-string behaviour: https://3v4l.org/ECZjp#v8.3.6
This way we are sure we get exactly what PHP evalutes.
There was a problem hiding this comment.
Looks like is_numeric would do the job: https://3v4l.org/sYolO#v8.3.6
There was a problem hiding this comment.
Not really, those are both numeric, but results in different output type: https://3v4l.org/aDslS#v8.3.6
There was a problem hiding this comment.
There is a similar open PR you might can get inspiration from
| Superseded by #2796 |
3 participants
Probably fixes even phpstan/phpstan#10125
Found in https://github.com/shipmonk-rnd/phpstan-rules tests when run with new 204ab27