V6 compatibility #35
Merged
V6 compatibility #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
the `FOS\ElasticaBundle\Persister\Event\Events` class was removed in 6.0 so we need to use event classes instead
Elasticsearch 7 and FOSElasticaBundle 6 no longer use types (only indexes)
| Hello, Do you think it will merge? |
| @makasim ping :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The FOSElasticaBundle v6 has a lot of BC breaks so in order to support it, we need to drop support for v5 and fix some BC issues.