Do not pass :for_input to super if it was used for tag groups #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The plugin reuses the for_input tag to designate tags from specific tag groups. However, core expects that :for_input is used with a category, and if there are tag group restrictions it will honor them. If :for_input is passed to core without a category, any tags that contain to a tag group that is used in ANY category as a restricted tag group, are not returned. This makes the plugin unusable for assigning tags from restricted tag groups to a topic. At the moment CW uses the tag picker, it's not clear to which category the topic is going to be in, so passing the category together with :for_input is not an option. The only option left to make this work is to remove :for_input. This behavior is the same in the "experimental form templates" functionality, that also ignores restrictions on tag groups.
| Thanks Richard! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
After testing this further, I am convinced that this is the issue (and the solution)
The plugin reuses the for_input tag to designate tags from specific tag groups.
However, core expects that :for_input is used with a category, and if there are tag group restrictions it will honor them.
If :for_input is passed to core without a category, any tags that contain to a tag group that is used in ANY category as a restricted tag group, are not returned.
This makes the plugin unusable for assigning tags from restricted tag groups to a topic.
At the moment CW uses the tag picker, it's not clear to which category the topic is going to be in, so passing the category together with :for_input is not an option.
The only option left to make this work is to remove :for_input.
This behavior is the same in the "experimental form templates" functionality, that also ignores restrictions on tag groups.