add Geoopen as dbtype #136
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| The ASN data is structured differently than MaxMind databases and will not work. Although the country db, err := maxminddb.Open("latest.mmdb") if err != nil { return err } var countryCode string err = db.Lookup(ip).DecodePath(&countryCode, "country", "iso_code") if err != nil { return err } |
Author
| Can we just add the Country one ? |
Owner
| I don't think this adds any value over just using |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Luxembourg has open data available (ODC-BY 1.0 license):
https://data.public.lu/en/datasets/geo-open-ip-address-geolocation-per-country-in-mmdb-format/
Direct links:
https://cra.circl.lu/opendata/geo-open/mmdb-country-asn/latest.mmdb
https://cra.circl.lu/opendata/geo-open/mmdb-country/latest.mmdb
Can we add the db type ?