Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 30, 2025

Which problem is this PR solving?

These equality assertions can be flaky due to floating point math.

Fixes: https://github.com/open-telemetry/opentelemetry-js/actions/runs/18082260606/job/51447397928?pr=5962

Short description of the changes

This commit updates the assertions to allow a small threshold.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Existing test suite

Checklist:

  • Followed the style guidelines of this project
These equality assertions can be flaky due to floating point math. This commit updates the assertions to allow a small threshold.
@cjihrig cjihrig requested a review from a team as a code owner September 30, 2025 20:12
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.17%. Comparing base (09bf31e) to head (4c6d26b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #5974 +/- ## ======================================= Coverage 95.17% 95.17% ======================================= Files 316 316 Lines 8521 8521 Branches 1763 1763 ======================================= Hits 8110 8110 Misses 411 411 
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🙂

@pichlermarc pichlermarc enabled auto-merge October 1, 2025 08:04
@pichlermarc pichlermarc added this pull request to the merge queue Oct 1, 2025
Merged via the queue into open-telemetry:main with commit a594098 Oct 1, 2025
25 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Oct 1, 2025

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the threshold branch October 1, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants