Update OtlpMetricExporterProvider to implement AutoConfigureListener #7541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #7541 +/- ## ========================================= Coverage 90.01% 90.01% - Complexity 7080 7092 +12 ========================================= Files 803 803 Lines 21417 21450 +33 Branches 2086 2092 +6 ========================================= + Hits 19278 19309 +31 Misses 1477 1477 - Partials 662 664 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask approved these changes Aug 12, 2025
jkwatson reviewed Sep 9, 2025
| config, builder::setAggregationTemporalitySelector); | ||
| ExporterBuilderUtil.configureOtlpHistogramDefaultAggregation( | ||
| config, builder::setDefaultAggregationSelector); | ||
| builder.setMeterProvider(meterProviderRef::get); |
There was a problem hiding this comment.
I feel like it would be good to make sure we have tests that cover this particular line. The test addition doesn't seem to verify that we're actually doing this very important step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #7522
Makes
OtlpMetricExporterProviderimplementAutoConfigureListenerlike the other exporter providers, and callsbuilder.setMeterProvider(meterProviderRef::get)when configuring the builder.