- Notifications
You must be signed in to change notification settings - Fork 923
Incubating: Add minimum severity and trace-based logger configuration #7529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incubating: Add minimum severity and trace-based logger configuration #7529
Conversation
…ers (#4612) Alternative to #4611 Some related prior discussions: - #4208 (comment) - #4207 (comment) Java POC @ open-telemetry/opentelemetry-java#7529 Declarative config for this is a bit nicer than in #4611, also supports applying different minimum severity levels to different loggers: ``` file_format: "1.0" logger_provider: logger_configurator/development: default_config: minimum_severity: WARN trace_based: true loggers: - name: "com.example.app.*" config: minimum_severity: INFO - name: "com.example.db.*" config: minimum_severity: ERROR ``` --------- Co-authored-by: Liudmila Molkova <neskazu@gmail.com> Co-authored-by: Robert Pająk <pellared@hotmail.com>
747bc91 to f607dc9 Compare Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #7529 +/- ## ============================================ + Coverage 90.16% 90.21% +0.04% - Complexity 7229 7247 +18 ============================================ Files 821 822 +1 Lines 21809 21828 +19 Branches 2136 2139 +3 ============================================ + Hits 19665 19693 +28 + Misses 1472 1469 -3 + Partials 672 666 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d8f0544 to c471c04 Compare c471c04 to 6d538c3 Compare sdk/logs/src/main/java/io/opentelemetry/sdk/logs/internal/LoggerConfig.java Show resolved Hide resolved
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/SdkLogRecordBuilder.java Show resolved Hide resolved
ff37f15 to 7131c10 Compare 7131c10 to a88392e Compare sdk/logs/src/main/java/io/opentelemetry/sdk/logs/internal/LoggerConfig.java Outdated Show resolved Hide resolved
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/internal/LoggerConfig.java Outdated Show resolved Hide resolved
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/internal/LoggerConfig.java Show resolved Hide resolved
…d-trace-based-log-configuration
| @jack-berg now that open-telemetry/opentelemetry-configuration#392 is merged, would you like me to add declarative config support in this PR or in a follow-up? |
| Followup is great. We need to wait for declarative config to cut a release anyway. No point in holding this up. |
Incubating implementation for open-telemetry/opentelemetry-specification#4612