Skip to content

Conversation

@jack-berg
Copy link
Member

Agent extensions aren't currently able to provide declarative configuration ComponentProvider SPI implementations because the agent requires a them to be loaded using a particular class loader.

This adds a new FileConfiguration#create overload which allows SpiHelper (which is based on a ClassLoader) to be specified, and updates AutoConfiguredOpenTelemetrySdkBuilder to call this new method.

@jack-berg jack-berg requested a review from a team September 16, 2024 20:52
@codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.06%. Comparing base (39b2411) to head (16a4e67).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nfigure/AutoConfiguredOpenTelemetrySdkBuilder.java 90.90% 1 Missing ⚠️
...ension/incubator/fileconfig/FileConfiguration.java 92.30% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## main #6725 +/- ## ========================================= Coverage 90.06% 90.06% - Complexity 6457 6463 +6  ========================================= Files 718 718 Lines 19511 19528 +17 Branches 1922 1923 +1 ========================================= + Hits 17572 17588 +16  Misses 1350 1350 - Partials 589 590 +1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg requested a review from a team as a code owner September 20, 2024 18:44
@jack-berg jack-berg merged commit 325822c into open-telemetry:main Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants