make SdkTracer.tracerEnabled mutable #6687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #6687 +/- ## ============================================ + Coverage 90.00% 90.02% +0.01% - Complexity 6332 6353 +21 ============================================ Files 703 703 Lines 19092 19138 +46 Branches 1883 1887 +4 ============================================ + Hits 17184 17229 +45 - Misses 1332 1333 +1 Partials 576 576 ☔ View full report in Codecov by Sentry. |
jack-berg reviewed Sep 5, 2024
sdk/trace/src/main/java/io/opentelemetry/sdk/trace/SdkTracer.java Outdated Show resolved Hide resolved
jack-berg approved these changes Sep 5, 2024
jack-berg reviewed Sep 5, 2024
Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This allows the tracer to become enabled and disabled dynamically (though only by reflection at this stage). Doing just this change allows downstream agent distros to play around with APIs that would best work while not yet changing anything public in the SDK
Without this change, testing downstream is still possible but much more effortful