Check graph outputs are defined #6083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #6083 +/- ## ========================================== + Coverage 56.95% 57.05% +0.09% ========================================== Files 506 506 Lines 30467 30489 +22 Branches 4592 4593 +1 ========================================== + Hits 17353 17394 +41 + Misses 12285 12269 -16 + Partials 829 826 -3 ☔ View full report in Codecov by Sentry. |
justinchuby approved these changes Apr 12, 2024
gramalingam added a commit to gramalingam/onnx that referenced this pull request Jun 6, 2024
The current checker does not check that all graph outputs are defined. This PR adds such a check. (See issue onnx#6040 ). Note: We probably also want a separate check to ensure that a graph-input is not used as a graph-output. But leaving that for a separate PR, since it is a distinctly different check (and perhaps might require a different discussion). Redo of PR onnx#6070 Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
andife pushed a commit to andife/onnx that referenced this pull request Jul 20, 2024
The current checker does not check that all graph outputs are defined. This PR adds such a check. (See issue onnx#6040 ). Note: We probably also want a separate check to ensure that a graph-input is not used as a graph-output. But leaving that for a separate PR, since it is a distinctly different check (and perhaps might require a different discussion). Redo of PR onnx#6070 Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
The current checker does not check that all graph outputs are defined. This PR adds such a check. (See issue onnx#6040 ). Note: We probably also want a separate check to ensure that a graph-input is not used as a graph-output. But leaving that for a separate PR, since it is a distinctly different check (and perhaps might require a different discussion). Redo of PR onnx#6070 Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The current checker does not check that all graph outputs are defined. This PR adds such a check. (See issue #6040 ).
Note: We probably also want a separate check to ensure that a graph-input is not used as a graph-output. But leaving that for a separate PR, since it is a distinctly different check (and perhaps might require a different discussion).
Redo of PR #6070