Update copy_io.c #53
Merged
Update copy_io.c #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
changed chars to ints to avoid "comparison between pointer and integer gcc" warning
ohkimur requested changes Jul 10, 2023
chapter_1/exercise_1_09/copy_io.c Outdated
Comment on lines 7 to 13
| /* | ||
| If I use chars here instead of ints I get a "comparison | ||
| between pointer and integer gcc" warning. | ||
| getchar returns int not char. | ||
| Char type is de facto a 1-byte integer type. | ||
| Thank you for you solutions, they're helping me learn. | ||
| */ |
There was a problem hiding this comment.
Please remove your comment here, and we can merge your fix.
There was a problem hiding this comment.
Done. Thank you :)
ohkimur approved these changes Jul 10, 2023
| @4rturkania Thanks for your contribution! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
changed chars to ints to avoid "comparison between pointer and integer gcc" warning