chore: add clean() test for build metadata #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Was there more you wanted to do here? |
Nope, that's all. Personally, I didn't realize that semver considers versions that differ by only the build metadata to be equal in precedent... so when I noticed that I then read the semver spec more closely and everything made sense. |
You can mark this as ready then. |
wraithgar approved these changes Nov 30, 2023
Doh, forgot that it was in draft status. 🤦 |
Merged
wraithgar pushed a commit that referenced this pull request Feb 5, 2024
🤖 I have created a release *beep* *boop* --- ## [7.6.0](v7.5.4...v7.6.0) (2024-01-31) ### Features * [`a7ab13a`](a7ab13a) [#671](#671) preserve pre-release and build parts of a version on coerce (#671) (@madtisa, madtisa, @wraithgar) ### Chores * [`816c7b2`](816c7b2) [#667](#667) postinstall for dependabot template-oss PR (@lukekarrys) * [`0bd24d9`](0bd24d9) [#667](#667) bump @npmcli/template-oss from 4.21.1 to 4.21.3 (@dependabot[bot]) * [`e521932`](e521932) [#652](#652) postinstall for dependabot template-oss PR (@lukekarrys) * [`8873991`](8873991) [#652](#652) chore: chore: postinstall for dependabot template-oss PR (@lukekarrys) * [`f317dc8`](f317dc8) [#652](#652) bump @npmcli/template-oss from 4.19.0 to 4.21.0 (@dependabot[bot]) * [`7303db1`](7303db1) [#658](#658) add clean() test for build metadata (#658) (@jethrodaniel) * [`6240d75`](6240d75) [#656](#656) add missing quotes in README.md (#656) (@zyxkad) * [`14d263f`](14d263f) [#625](#625) postinstall for dependabot template-oss PR (@lukekarrys) * [`7c34e1a`](7c34e1a) [#625](#625) bump @npmcli/template-oss from 4.18.1 to 4.19.0 (@dependabot[bot]) * [`123e0b0`](123e0b0) [#622](#622) postinstall for dependabot template-oss PR (@lukekarrys) * [`737d5e1`](737d5e1) [#622](#622) bump @npmcli/template-oss from 4.18.0 to 4.18.1 (@dependabot[bot]) * [`cce6180`](cce6180) [#598](#598) postinstall for dependabot template-oss PR (@lukekarrys) * [`b914a3d`](b914a3d) [#598](#598) bump @npmcli/template-oss from 4.17.0 to 4.18.0 (@dependabot[bot]) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced May 24, 2024
This was referenced Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds a test for
semver.cleanthat demonstrates how the function strips build metadata.References