Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 26, 2025

Remove stale comment

References

This comment was originally written like this:

// only update the notification timeout if we actually finished checking
module.exports = async npm => {
const notification = await updateNotifier(npm)
// intentional. do not await this. it's a best-effort update.
updateTimeout(npm)
npm.updateNotification = notification

The code that updates the timeout is no longer anywhere close to this comment:

// intentional. do not await this. it's a best-effort update. if this
// fails, it's ok. might be using /dev/null as the cache or something weird
// like that.
writeFile(lastCheckedFile(npm), '').catch(() => {})

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref requested a review from a team as a code owner September 26, 2025 18:29
@owlstronaut owlstronaut merged commit bb4b739 into npm:latest Sep 26, 2025
20 checks passed
@github-actions github-actions bot mentioned this pull request Sep 25, 2025
@jsoref jsoref deleted the remove-stale-comment branch September 26, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants