Add direct conversion from SockAddrIn(6) to SocketAddr #2474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pronebird force-pushed the sa46-to-sockaddr branch from f722db6 to 12e35d7 Compare 
pronebird force-pushed the sa46-to-sockaddr branch from 12e35d7 to c6cb19a Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do
At the moment nix only offers conversions between
SockaddrIn->SocketAddrV4andSockaddrIn6->SocketAddrV6but no conversions to the container type,SocketAddritself.While it's trivial to wrap either
SocketAddrV4orSocketAddrV6intoSocketAddr, I think having a shortcut would improve ergonomics and essentially align nix with std, which supportsFromconversions fromSocketAddrV{4,6}toSocketAddr.Checklist:
CONTRIBUTING.md