Skip to content

fix: don't pipe plugin output more than once at the time #6765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

fix: don't pipe plugin output more than once at the time #6765

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e80c06
fix: don't pipe plugin output more than once at the time
pieh Nov 4, 2025
f829e13
fix types
pieh Nov 4, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions packages/build/src/log/stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,25 @@ const pushBuildCommandOutput = function (output: string, logsArray: string[]) {
logsArray.push(output)
}

const pipedPluginProcesses = new WeakMap<ChildProcess, ReturnType<typeof pipePluginOutput>>()

// Start plugin step output
export const pipePluginOutput = function (childProcess: ChildProcess, logs: Logs, standardStreams: StandardStreams) {
if (!logsAreBuffered(logs)) {
return streamOutput(childProcess, standardStreams)
export const pipePluginOutput = function (
childProcess: ChildProcess,
logs: Logs,
standardStreams: StandardStreams,
): LogsListeners | undefined {
if (pipedPluginProcesses.has(childProcess)) {
return pipedPluginProcesses.get(childProcess)
}

return pushOutputToLogs(childProcess, logs, standardStreams.outputFlusher)
const listeners = !logsAreBuffered(logs)
? streamOutput(childProcess, standardStreams)
: pushOutputToLogs(childProcess, logs, standardStreams.outputFlusher)

pipedPluginProcesses.set(childProcess, listeners)

return listeners
}

// Stop streaming/buffering plugin step output
Expand All @@ -71,10 +83,12 @@ export const unpipePluginOutput = async function (
}

unpushOutputToLogs(childProcess, listeners.stdoutListener, listeners.stderrListener)

pipedPluginProcesses.delete(childProcess)
Copy link
Contributor Author

@pieh pieh Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this delete case is not hit if we return early in line 82, which would prevent from re-piping again in that case
}

// Usually, we stream stdout/stderr because it is more efficient
const streamOutput = function (childProcess: ChildProcess, standardStreams: StandardStreams) {
const streamOutput = function (childProcess: ChildProcess, standardStreams: StandardStreams): undefined {
childProcess.stdout?.pipe(standardStreams.stdout)
childProcess.stderr?.pipe(standardStreams.stderr)
}
Expand Down
Loading