Skip to content

Conversation

@pieh
Copy link
Contributor

@pieh pieh commented Nov 4, 2025

🎉 Thanks for submitting a pull request! 🎉

Summary

#5899 made output unpiping conditional, however we still are piping for every hook leading to duplicated logs like so:

onBuild called onBuild called onPostBuild called onPostBuild called onPostBuild called onSuccess called onSuccess called onSuccess called onSuccess called onEnd called onEnd called onEnd called onEnd called onEnd called 

with number of repetitions increasing by one with each hook.

This attempts to ensure we don't have multiple active pipes, by return early if process was piped before without being unpiped


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@pieh pieh marked this pull request as ready for review November 5, 2025 08:36
@pieh pieh requested a review from a team as a code owner November 5, 2025 08:36
@pieh pieh merged commit 08dad8d into main Nov 5, 2025
54 of 55 checks passed
@pieh pieh deleted the fix/dont-duplicate-build-plugin-output branch November 5, 2025 08:37
pieh added a commit that referenced this pull request Nov 6, 2025

unpushOutputToLogs(childProcess, listeners.stdoutListener, listeners.stderrListener)

pipedPluginProcesses.delete(childProcess)
Copy link
Contributor Author

@pieh pieh Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this delete case is not hit if we return early in line 82, which would prevent from re-piping again in that case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants