Quick fix for the new API rule for \all route #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The API provider is now requiring requests for this endpoint to specify upto 10 fields (https://gitlab.com/restcountries/restcountries/-/issues/265)
The type of the borders array returned by the API is optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The API provider recently enforced adding fields to the \all endpoint. This PR fixes the issue by adding the necessary fields to the all countries endpoint.
In addition, the endpoint \name does not always return the borders for the country which causes the country view to break in the app - I don't know if this is new or not. The PR addresses this issue by making the relevant types optional.