Skip to content

Conversation

@rokon-uddin
Copy link
Collaborator

Description

Please include a summary of the changes and the related issues. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

All Submissions:

  • Does your code follows the Style Guidelines of this project?
  • Does your commit message follows the Conventional Commits?
  • Did you make sure your changes generate no new warnings?
  • Did you ensure new and existing unit tests pass locally with your changes?
  • Have you performed a self-review of my code?
  • Have you commented on your code, particularly in hard-to-understand areas?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you followed the guidelines in our Contributing Document?

New Feature Submissions:

  • Have you added tests that prove that your feature works?
  • Have you lint your code locally before submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
Copy link
Contributor

@Arman-Morshed Arman-Morshed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

static func view(_: ViewAction) -> Self
static func delegate(_: DelegateAction) -> Self
static func inlying(_: InlyingAction) -> Self
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we currently do not use BaseAction.

// .tryCatch { _ in self.coreDataManager.localRandom() }
// .mapError { NetworkingError.error($0.localizedDescription) }
// .eraseToAnyPublisher()
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this commented code?

@rokon-uddin rokon-uddin merged commit b6a161d into ml-opensource:main Feb 12, 2024
@rokon-uddin rokon-uddin deleted the refactor_repository branch February 12, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants