Fix breaking change - Revert "[11.x] Replace string class names with ::class constants" #54185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit aed6bbe.
GrahamCampbell approved these changes Jan 14, 2025
SanderMuller added a commit to SanderMuller/framework that referenced this pull request Jan 14, 2025
| The same test change has been added in #54186 which shows that the added test fails on the |
shaedrich reviewed Jan 14, 2025
Comment on lines +253 to +254
| '\Illuminate\Routing\RedirectController', | ||
| '\Illuminate\Routing\ViewController', |
There was a problem hiding this comment.
Suggested change
| '\Illuminate\Routing\RedirectController', | |
| '\Illuminate\Routing\ViewController', | |
| '\\' . Illuminate\Routing\RedirectController::class, | |
| '\\' . Illuminate\Routing\ViewController::class, |
probably isn't much better, is it?
taylorotwell pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reverts #54134
fixed #54184
@taylorotwell I think this is a breaking change on the old route namespacing eg
this now throws
Invalid route action: [App\Http\Controllers\Admin\Illuminate\Routing\ViewController].because the namespace in this PR was changed from\Illuminate\Routing\ViewControllertoIlluminate\Routing\ViewControllerI think.