[11.x] Make methods of HasRelationships generic #54174
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR introduces generics to the
relationResolver,newRelatedInstance, andnewRelatedThroughInstancemethods in theHasRelationshipstrait. By leveraging generics, these methods now provide stricter type checking for related models, improving developer experience and code predictability.Key Changes:
relationResolvermethod, refining the return type toClosure|null.newRelatedInstanceandnewRelatedThroughInstanceto ensure they return specific related model instances.@templateand@paramto enforce stricter type handling.Benefits:
Before:
After:
This change is backward-compatible, maintaining existing functionality while improving the reliability and clarity of type handling in Eloquent relation methods.