Skip to content

[11.x] fix times() calls #54141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

[11.x] fix times() calls #54141

merged 1 commit into from
Jan 9, 2025

Conversation

@browner12
Copy link
Contributor

@browner12 browner12 commented Jan 9, 2025

times() is a static method on the factory, and should be called as such, not as an instance method.

times() also already calls new() so no reason to do it twice.
@browner12
fix times() calls
1f6beac 
`times()` is a static method on the factory, and should be called as such, not as an instance method. `times()` also already calls `new()` so no reason to do it twice.
@taylorotwell taylorotwell merged commit d66b6c0 into laravel:11.x Jan 9, 2025
40 checks passed
@browner12 browner12 deleted the AB-fix-times-calls branch January 9, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@browner12 @taylorotwell