Add $bind parameter to Blade::directive #53279
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I submitted the same PR a few days ago, but it was closed with an unrelated response and wasn’t properly reviewed. I was advised by your colleagues to resubmit it and be clearer. my previous PR #53222
Description
Let's say we want to have a custom
@extendsdirective:Currently, this is impossible without modifying files in the
./vendordirectory. My changes would be lost if I upgraded Laravel.Solution
$this->footeris a protected property inBladeCompiler::classwhich is used insideCompilesLayouts::compileExtends()framework/src/Illuminate/View/Compilers/Concerns/CompilesLayouts.php
Line 26 in 4b5ce19
Default Behavior of the Blade::directive without the
$bindparam🟢 Setting the
$bindparam totrueWe can create advanced directives now