🐛Panic when trying to build more than one instance of fake.ClientBuilder #3314
+14 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
k8s-ci-robot added the cncf-cla: yes k8s-ci-robot added the size/S 
alvaroaleman reviewed Sep 9, 2025
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
alvaroaleman added the tide/merge-method-squash alvaroaleman approved these changes Sep 9, 2025
k8s-ci-robot added the lgtm 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, troy0820 The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| LGTM label has been added. Git tree hash: 17bd5a65afd42f7281c7380003307832d4338eb1 |
k8s-ci-robot added the approved 
| thanks! |
| /cherry-pick release-0.22 |
| @troy0820: new pull request created: #3315 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using
fake.NewClientBuilder, you recieve aclient.WithWatch. However, having many instances of thefake.ClientBuildercan cause issues when trying to callBuild()where the behavior is inconsistent in testing.This will now panic when trying to use two instances of the clientBuilder and using build in both of those instances.
Resolves #3313