🐛 Fakeclient: Update passed object in Apply #3283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
k8s-ci-robot added the cncf-cla: yes k8s-ci-robot added approved 
Currently, the object that is passed into the fakeclients `Apply` will not get updated, this change fixes that. It also adds tests that validate that all mutating methods except Delete update the object.
alvaroaleman force-pushed the fix-unmarshal branch from f3126bc to 4bfda0b Compare 
| Thx! /lgtm |
k8s-ci-robot added the lgtm 
| LGTM label has been added. Git tree hash: 4b6776d3caf7c4622794ce7f0a2ce8e91fee5b7b |
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, the object that is passed into the fakeclients
Applywill not get updated, this change fixes that. It also adds tests that validate that all mutating methods except Delete update the object.