Skip to content

Conversation

@joesho112358
Copy link
Contributor

Noticed some things that might improve the readability in the activations.py file

@gbaned gbaned requested a review from qlzh727 February 9, 2023 17:25
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Feb 9, 2023
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@google-ml-butler google-ml-butler bot added the ready to pull Ready to be merged into the codebase label Feb 9, 2023
@grasskin grasskin removed the keras-team-review-pending Pending review by a Keras team member. label Feb 10, 2023
copybara-service bot pushed a commit that referenced this pull request Feb 14, 2023
Imported from GitHub PR #17545 Noticed some things that might improve the readability in the `activations.py` file Copybara import of the project: -- c1a43df by joe <joesho112358@gmail.com>: simplifying some logic and renaming a couple variables -- 0d6e2f2 by joe <joesho112358@gmail.com>: renaming a couple variables correctly this time Merging this change closes #17545 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17545 from joesho112358:activations_clean_up 0d6e2f2 PiperOrigin-RevId: 509551172
@copybara-service copybara-service bot merged commit d2fd1ec into keras-team:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull Ready to be merged into the codebase size:S

5 participants